[PATCH] D46893: [CVP] Require DomTree for new Pass Manager

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:760
   LazyValueInfo *LVI = &AM.getResult<LazyValueAnalysis>(F);
-  bool Changed = runImpl(F, LVI, getBestSimplifyQuery(AM, F));
 
----------------
And this makes it somewhat obvious that this patch is an incremental improvement -- it removes one dynamic aspect of this. So, this patch definitely LGTM, but I think we also want to think about what a better API for building SimplifyQuery looks like in the new PM world where we have more of these issues around cached analyses being unpredictable.


https://reviews.llvm.org/D46893