[PATCH] D38768: Add remarks describing when a pass changes the IR instruction count of a module

[Jessica Paquette via Phabricator via llvm-commits]

paquette updated this revision to Diff 147543.
paquette marked 4 inline comments as done.
paquette added a comment.

Updated patch to address review.

- Fixed stylistic issues
- Changed the basic block instruction count as per @efriedma's suggestion
- Tightened up the logic in `emitInstrCountChangedRemark`
- Fixed up the leftover int in `Function::getInstructionCount`
- Small personal nit on the test. `[[DELTA:-*[1-9][0-9]*]]`->`[[DELTA:-?[1-9][0-9]*]]`. The negative sign should have 0 or 1 repetitions, not 0 or more.


https://reviews.llvm.org/D38768

Files:
  include/llvm/IR/Function.h
  include/llvm/IR/LegacyPassManagers.h
  include/llvm/IR/Module.h
  lib/Analysis/CallGraphSCCPass.cpp
  lib/Analysis/LoopPass.cpp
  lib/IR/Function.cpp
  lib/IR/LegacyPassManager.cpp
  lib/IR/Module.cpp
  test/Other/size-remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38768.147543.patch
Type: text/x-patch
Size: 16551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180518/eaebaea3/attachment.bin>