[PATCH] D46815: [DbgInfo] Fix StripDebugInfo
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 18 09:12:28 PDT 2018
vsk added inline comments.
================
Comment at: tools/opt/opt.cpp:759
- Passes.add(createCheckDebugifyModulePass(false));
+ Passes.add(createCheckDebugifyModulePass(StripDebug));
----------------
vsk wrote:
> Why is this change needed? It doesn't seem related to the StripDebugInfo utility.
To clarify, I don't think this change belongs in this patch. There are two different issues here. The first is that the StripDebugInfo function doesn't remove declarations of debug intrinsics. And the second is that opt's -strip-debug mode runs too early.
Can you address only the first issue with this patch?
https://reviews.llvm.org/D46815
More information about the llvm-commits
mailing list