[PATCH] D47073: Document and Enforce new Host Compiler Policy

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:17
+      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.1)
+        message(FATAL_ERROR "Host GCC version must be at least 5.1!")
+      endif()
----------------
Is it possible to define meaningful variable names for all the various version numbers, and set them all at the top near the commentary describing the policy?  I know these lines aren't all *that* far away, but it just seems like good engineering practice.  Especially as the intent is to update these possibly as often as twice a year from now on.


https://reviews.llvm.org/D47073