[PATCH] D46992: [AMDGPU] Add perf hints to functions

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUPerfHint.cpp:166
+
+bool AMDGPUPerfHint::isIndirectAccess(const Instruction *Inst) const {
+  DEBUG(dbgs() << "[isIndirectAccess] " << *Inst << '\n');
----------------
arsenm wrote:
> What does this mean exactly by indirect access?
> 
> This seems to me like it's reimplementing something like GetUnderlyingObject
indirect access here means something like a[b[i]], i.e., the index of the array is loaded from memory. It usually results in random access in stead of stream access. Probably it can have a better name.


https://reviews.llvm.org/D46992