[PATCH] D46756: [AMDGPU] Reworked SIFixWWMLiveness
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 18 01:31:30 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIFixWWMLiveness.cpp:238
+ auto DomDefBlock = Defs[0]->getParent();
+ if (DomDefBlock->succ_size() == 2 && MRI->hasOneUse(Reg)) {
+ auto UseBlock = MRI->use_begin(Reg)->getParent()->getParent();
----------------
Without looking at this too closely, I would like to avoid adding assumptions where the number of successors of a block is exactly 2 to avoid future pain when control flow lowering is changed. Is there a more specific property you can check instead?
Repository:
rL LLVM
https://reviews.llvm.org/D46756
More information about the llvm-commits
mailing list