[PATCH] D47026: [DAG] fold FP binops with undef operands to NaN

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D47026#1103526, @jlebar wrote:

> > NVPTX/implicit-def.ll - this isn't testing what it intended to test, but I don't know how to do that...could just delete the file?
>
> This test is from 2013 and hasn't had a meaningful change since then.  It's not totally clear to me what it's testing, but it looks like it's checking for a crasher.
>
> I suspect that in the years since then we're a-ok on covering this.  I support deleting it.
>
> (Or if you want to fix up the test like you have it here, that's also OK with me.)


I think it's better to remove it since there is no implicit def possibility if we fold the undef to NaN. Keeping it around will just confuse others about the intent if it needs changing in the future.


https://reviews.llvm.org/D47026