[PATCH] D47005: [WebAssembly] Add MachineBasicBlock::isEHScopeEntry & setIsEHScopeEntry

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/CodeGen/Analysis.cpp:679
   for (const MachineBasicBlock &MBB : MF) {
-    if (MBB.isEHFuncletEntry()) {
+    if (MBB.isEHScopeEntry()) {
       FuncletBlocks.push_back(&MBB);
----------------
dschuff wrote:
> If this code only cares about whether a block is in a scope (as opposed to a funclet), should the variable names and/or comments here be updated too?
Done. Ended up renaming a few methods and adding `MachineFunction::hasEHScopes` and `MachineFunction::setHasEHScopes`.
This function has been renamed as not `getScopeMembership` but `getEHScopeMembership` because this function is being used in many places and 'scope' only sounds little too general and ambiguous.


Repository:
  rL LLVM

https://reviews.llvm.org/D47005