[PATCH] D46893: [CVP] Require DomTree for new Pass Manager

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

I may have sowed some confusion here by not updating commit messages as the code changed.

The code here in CVP currently:

- use getBestSimplifyQuery to get the best SQ available (but not require a DT in the NPM)
- use the SQ in SQ.DT->dominates (causing the problem) and SimplifyInstruction(.., SQ)

With this patch it:

- gets DT directly and passes it through to where it's needed (i.e DT->dominates)
- uses getBestSimplifyQuery only for SimplifyInstruction(.., SQ)
- no longer uses SQ.DT directly

Everyone happy (enough) with this state of affairs?


https://reviews.llvm.org/D46893