[PATCH] D47046: [WebAssembly] Object: Add more error checking for object file reading

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 21:37:10 PDT 2018


jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.

One comment, lgtm otherwise.



================
Comment at: lib/Object/WasmObjectFile.cpp:961
     uint32_t Size = readVaruint32(Ptr);
+    if (Size > End - Ptr)
+      return make_error<GenericBinaryError>("Invalid segment size",
----------------
That seems like readvaruint32 went out of valid range, no?


Repository:
  rL LLVM

https://reviews.llvm.org/D47046





More information about the llvm-commits mailing list