[PATCH] D46456: [asan] Add support for Myriad RTEMS memory map

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl accepted this revision.
alekseyshl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/asan/asan_mapping.h:153
+static const u64 kMyriadShadowScale = 5;
 #endif
 static const u64 kDefaultShadowSentinel = ~(uptr)0;
----------------
How about dropping kMyriadShadowScale:

  #if defined(ASAN_SHADOW_SCALE)
  static const u64 kDefaultShadowScale = ASAN_SHADOW_SCALE;
  #elif defined(SANITIZER_MYRIAD2)
  static const u64 kDefaultShadowScale = 5;
  #else
  static const u64 kDefaultShadowScale = 3;
  #endif

then you won't need to fiddle with SHADOW_SCALE defines


Repository:
  rL LLVM

https://reviews.llvm.org/D46456