[llvm] r332452 - [SimplifyLibcalls] Replace locked IO with unlocked IO

[Eric Christopher via llvm-commits]

On Wed, May 16, 2018 at 3:09 PM Friedman, Eli via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On 5/16/2018 2:54 PM, Benjamin Kramer via llvm-commits wrote:
> > This triggered a really annoying miscompile (see r332531), and it's even
> > present in the test case. Please double check your tests, especially when
> > using update_test_checks.py.
> >
> > Also you want to get these things reviewed by someone who's actually
> > familiar with the LLVM before they land.
>
> I looked at the patch multiple times, and never spotted this issue.
> Granted, maybe I should have looked a little more carefully at that part
> of the patch (I was more focused on the actual transform).
>

Probably would have helped here if you'd ack'd the patch yourself. The only
approval on the patch is an anonymous person with no llvm history (as far
as I can tell).

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180517/3293a440/attachment.html>