[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.

[Justin Lebar via Phabricator via llvm-commits]

jlebar marked an inline comment as done.
jlebar added inline comments.


================
Comment at: External/CUDA/complex.cu:24
 // libstdc++ (compile errors in <complex>).
-#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \
-    (__cplusplus < 201402L || STDLIB_VERSION >= 2014)
+#if __cplusplus >= 201103L && (__cplusplus < 201402L || STDLIB_VERSION >= 2014)
 
----------------
tra wrote:
> Is this specific to c++14 only, or will we have similar conditions for c++17,20, etc?
> Perhaps we could express library version requirements as `STDLIB_VERSION >= (__cplusplus / 100)` ?
> I'm OK with either way.
> 
> 
I think it's specific to c++14 -- or at least, it's not necessarily a general problem.  The other benchmarks work with C++14 compiler plus C++11 stdlib -- it's just <complex> that gives us problems in the particular gcc versions we happen to use.


Repository:
  rT test-suite

https://reviews.llvm.org/D46995