[PATCH] D47019: [X86] Lowering rotation intrinsics to native IR

[Roland Scheidegger via Phabricator via llvm-commits]

sroland added a comment.

I don't really feel qualified to review this. But fwiw in mesa we never used rotate instructions, and for that matter we were not relying on shift intrinsics neither (we've got some cases where we actually need modulo width behavior so we're masking off the bits).
But omg do the larger-or-equal to bit width cases make things more complex... Shift is such a nice instruction - if just everybody could agree what the behavior should be when the shift count is larger than the bit width...


Repository:
  rL LLVM

https://reviews.llvm.org/D47019