[PATCH] D46866: [EarlyCSE] Avoid a poorly defined instruction comparison

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:219
+    // Flipped predicate is poorly defined if the operands are the same.
+    if (LHSCmp->getOperand(0) == LHSCmp->getOperand(1))
+      return false;
----------------
If I'm reading this correctly, the problem only exists for fcmps not icmps right?  If so, please restrict the early return to fcmps.  


Repository:
  rL LLVM

https://reviews.llvm.org/D46866