[PATCH] D46200: Mitigate relocation overflow [part 2 of 2]

[Han Shen via Phabricator via llvm-commits]

shenhan marked an inline comment as done.
shenhan added inline comments.


================
Comment at: ELF/Writer.cpp:1710
+  OutputSection *DefaultOutSec;
+  if (Config->Pic || !(DefaultOutSec = findSection(".text")))
+    DefaultOutSec = Out::ElfHeader;
----------------
grimar wrote:
> We do not write like that I think: `!(DefaultOutSec = findSection(".text")`.
> Please move the assignment to the `DefaultOutSec` outside of the `if`.
> 
> I think `".text"` can be a default for both `Pic` and `!Pic` probably.
Revised. Thanks.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46200