[PATCH] D46912: StructurizeCFG: Adjust the loop depth for a subregion to order the nodes correctly

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 09:25:24 PDT 2018


cfang added a reviewer: dberlin.
cfang added a comment.

Thanks Justin for your comment. I added Daniel as a reviewer.

-RN1 ->RN2->RN3->

This patch fixes the issue regarding the ordering of a subregion. No matter what approach you are using, RN1, RN2 and RN3 should be neighbors in the ordered list.
But if RN2 is a subregion of a loop, the current loop depth based approach will inappropriately  misplaced RN2 in the list because it has different loop depth than that of RN1 and RN3.

The patch applies an adjusted loop depth for subregion to resolve this issue. It should be common in the structurization to collapse a subregion and consider it as a special node.


https://reviews.llvm.org/D46912





More information about the llvm-commits mailing list