[PATCH] D46192: Script to match open Phabricator reviews with potential reviewers

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Awesome, thanks Kristof! Two more nits, but overall this looks good to me.



================
Comment at: utils/Reviewing/find_interesting_reviews.py:9
+import os.path
+from phabricator import Phabricator
+import pickle
----------------
Usually `import` and `from` are grouped/sorted separately:

```
import a
import b 
import c
from a import foo
from b import bar
```


================
Comment at: utils/Reviewing/find_interesting_reviews.py:94
+class PhabReview(PhabObject):
+    object_kind = "Review"
+
----------------
If this is a constant I'd make it all caps. Same for the class below.


https://reviews.llvm.org/D46192