[PATCH] D46907: [llvm-mca] Introduce a sequential container of Stages

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: tools/llvm-mca/Backend.h:22
 #include "Scheduler.h"
+#include "llvm/ADT/SmallVector.h"
 
----------------
courbet wrote:
> andreadb wrote:
> > Is this include really needed? You implicitly get it from Dispatch.h
> I think it should be included:
> 
> https://llvm.org/docs/CodingStandards.html#minimal-list-of-includes
> 
> ```
> You must include all of the header files that you are using
> ```
> 
``` [...] you can include them either directly or indirectly through another header file ```

I guess, it is a matter of how you interpret it?
Given the low importance of this, I don't really mind if we keep the include.


https://reviews.llvm.org/D46907