[PATCH] D45773: [RISCV] Don't fold symbol diff
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 17 02:19:39 PDT 2018
asb added inline comments.
================
Comment at: include/llvm/MC/MCObjectStreamer.h:172
+private:
+ Optional<uint64_t> absoluteSymbolDiff(const MCSymbol *hi,
+ const MCSymbol *Lo);
----------------
asb wrote:
> hi -> Hi
On second thought, I'd be tempted to keep this helper as a static function and add an `MCAssembler &` parameter to it. It only has two callsites so it's not much hassle to update.
https://reviews.llvm.org/D45773
More information about the llvm-commits
mailing list