[PATCH] D47005: [WebAssembly] Add isEHScopeEntry / setIsEHScopeEntry

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 01:41:07 PDT 2018


aheejin added a comment.

I don't really know about SEH, but it looks like cleanup pads are treated as funclet entries in all personalities, whereas catchpads should not be treated as funclet entries in SEH, right? So I tried to preserve that semantics, but one thing I don't understand is why we have to set `isEHFuncletEntry` again in `findUnwindDestinations` again if we set them in `visitCatchPad` and `visitCleanupPad`. Anyway that's what the current code is doing and I tried to preserve the same behavior. I ran all existing tests including SEH ones and all of them passed (except XFAILs).


Repository:
  rL LLVM

https://reviews.llvm.org/D47005





More information about the llvm-commits mailing list