[PATCH] D47001: [Mips] Use addAliasForDirective rather than custom parsing logic for data directives

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 17 00:34:09 PDT 2018


asb added a comment.

Apologies, I missed that there is a test failure/change with this patch. Symbol h in micromips-label-test.s now looks like:

  Symbol {
    Name: h (40)
    Value: 0x8
    Size: 0
    Binding: Local (0x0)
    Type: None (0x0)
    Other [ (0x80)
      STO_MIPS_MICROMIPS (0x80)
    ]
    Section: .text (0x2)
  }

Rather than:

  Symbol {
    Name: h (40)
    Value: 0x8
    Size: 0
    Binding: Local (0x0)
    Type: None (0x0)
    Other: 0
    Section: .text (0x2)
  }

I'm not familiar with `STO_MIPS_MICROMIPS` so I'm not sure if this is a breaking change or not.


https://reviews.llvm.org/D47001





More information about the llvm-commits mailing list