[PATCH] D46466: [asan] Add AsanThread::Restart() to support thread restart
Walter Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 16 20:14:22 PDT 2018
waltl marked 2 inline comments as done.
waltl added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_thread.cc:124
+ PoisonShadow(stack_bottom_, stack_top_ - stack_bottom_, 0);
+}
+
----------------
alekseyshl wrote:
> Since this feature is very much RTEMS specific, maybe it's better to be kept in asan_rtems.cc? Stack bounds are exposed via thread->GetStackBounds().
The problem is thread->GetStackBounds() is private. I moved the definition of AsanThread::Restart() to asan_rtems.cc, but I still need the declaration in asan_thread.h. Let me know what you think.
Repository:
rL LLVM
https://reviews.llvm.org/D46466
More information about the llvm-commits
mailing list