[PATCH] D46456: [asan] Add support for Myriad RTEMS memory map

[Walter Lee via Phabricator via llvm-commits]

waltl marked 9 inline comments as done.
waltl added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_mapping_myriad.h:26
+
+#define kHighMemBeg    (kMyriadMemoryEnd32 + 1)
+
----------------
waltl wrote:
> alekseyshl wrote:
> > If you do not have a concept of high mem, why not set kHighMemBeg and kHighMemEnd to 0? It'll make other conditions more explicit.
> That's what I did originally.  Vitally suggested that I define things this way.  I'm fine with either.  The tradeoffs I see are:
> 
> - define as 0: cleaner conceptually, consistent with handling of mid memory.
> 
> - define as range [begin, begin - 1]: fewer changes required.
> 
I went back to setting kHighMemBeg to 0.



Repository:
  rL LLVM

https://reviews.llvm.org/D46456