[PATCH] D46466: [asan] Add AsanThread::Restart() to support thread restart

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 15:34:46 PDT 2018


alekseyshl added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_thread.cc:120
+  // Thread restart is a feature on RTEMS, where a thread may resume
+  // execution at an arbitrary function entry point, withbut its stack
+  // and TLS state reset.  This function handles the associated
----------------
withbut -> without


================
Comment at: compiler-rt/lib/asan/asan_thread.cc:124
+  PoisonShadow(stack_bottom_, stack_top_ - stack_bottom_, 0);
+}
+
----------------
Since this feature is very much RTEMS specific, maybe it's better to be kept in asan_rtems.cc? Stack bounds are exposed via thread->GetStackBounds().


Repository:
  rL LLVM

https://reviews.llvm.org/D46466





More information about the llvm-commits mailing list