[PATCH] D44090: [WebAssembly] Support instruction selection for catching exceptions
David Majnemer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 16 15:28:05 PDT 2018
majnemer added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1371-1374
+ if (IsWasmCXX)
+ return;
DAG.setRoot(DAG.getNode(ISD::CATCHPAD, getCurSDLoc(), MVT::Other, getControlRoot()));
----------------
I think this would be cleaner as:
if (!IsWasmCXX)
DAG.setRoot(DAG.getNode(ISD::CATCHPAD, getCurSDLoc(), MVT::Other, getControlRoot()));
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6181
+ case Intrinsic::wasm_landingpad_index: {
+ // TODO
+ return nullptr;
----------------
Maybe make fill in the TODO with a rough sketch of what it needs to do?
Repository:
rL LLVM
https://reviews.llvm.org/D44090
More information about the llvm-commits
mailing list