[PATCH] D46829: Require DominatorTree when requiring/preserving LoopInfo in the old pass manager

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 15:21:04 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/BranchProbabilityInfo.cpp:1008
+  // Else -break-crit-edges will hit an assert when updating LI (due to missing
+  // DT).
+  AU.addRequired<DominatorTreeWrapperPass>();
----------------
I don't think you need to specifically mention break-crit-edges here; just a brief explanation of the general problem is enough.


https://reviews.llvm.org/D46829





More information about the llvm-commits mailing list