[llvm] r332452 - [SimplifyLibcalls] Replace locked IO with unlocked IO

Friedman, Eli via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 15:09:24 PDT 2018


On 5/16/2018 2:54 PM, Benjamin Kramer via llvm-commits wrote:
> This triggered a really annoying miscompile (see r332531), and it's even
> present in the test case. Please double check your tests, especially when
> using update_test_checks.py.
>
> Also you want to get these things reviewed by someone who's actually
> familiar with the LLVM before they land.

I looked at the patch multiple times, and never spotted this issue. 
Granted, maybe I should have looked a little more carefully at that part 
of the patch (I was more focused on the actual transform).

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project



More information about the llvm-commits mailing list