[llvm] r332534 - [AArch64] preserve test intent by removing undef

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 14:57:58 PDT 2018


Author: spatel
Date: Wed May 16 14:57:57 2018
New Revision: 332534

URL: http://llvm.org/viewvc/llvm-project?rev=332534&view=rev
Log:
[AArch64] preserve test intent by removing undef

We need to clean up the DAG floating-point undef logic.
This process is similar to how we handled integer undef
logic in D43141.

And as we did there, I'm trying to reduce the patch by
changing tests that would probably become meaningless
once we correct FP undef folding.

Modified:
    llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll

Modified: llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll?rev=332534&r1=332533&r2=332534&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/arm64-collect-loh.ll Wed May 16 14:57:57 2018
@@ -661,7 +661,7 @@ define void @uninterestingSub(i8* nocapt
 @.str.89 = external unnamed_addr constant [12 x i8], align 1
 @.str.90 = external unnamed_addr constant [5 x i8], align 1
 ; CHECK-LABEL: test_r274582
-define void @test_r274582() {
+define void @test_r274582(double %x) {
 entry:
   br i1 undef, label %if.then.i, label %if.end.i
 if.then.i:
@@ -671,8 +671,8 @@ if.end.i:
 ; CHECK: .loh AdrpLdrGot
 ; CHECK: .loh AdrpAdrp
 ; CHECK: .loh AdrpLdr
-  %mul.i.i.i = fmul double undef, 1.000000e-06
-  %add.i.i.i = fadd double undef, %mul.i.i.i
+  %mul = fmul double %x, 1.000000e-06
+  %add.i.i.i = fadd double %mul, %mul
   %sub.i.i = fsub double %add.i.i.i, undef
   call void (i8*, ...) @callee(i8* getelementptr inbounds ([12 x i8], [12 x i8]* @.str.89, i64 0, i64 0), i8* getelementptr inbounds ([5 x i8], [5 x i8]* @.str.90, i64 0, i64 0), double %sub.i.i)
   unreachable




More information about the llvm-commits mailing list