[PATCH] D46703: [MC] Relax .fill size requirements

[Nirav Dave via Phabricator via llvm-commits]

niravd added inline comments.


================
Comment at: llvm/test/MC/AsmParser/assembler-expressions.s:57
+text3:
+	.fill (text3-text2)/4, 4, 0x12345678
+	nop
----------------
peter.smith wrote:
> I think we haven't got a big-endian test for .fill when the size is > 1. I think there is a Mips test that uses .fill (hilo-addressing) but it is only .fill 0x30124-8
> 
> Probably worth adding one to make sure that the endian reversal code is working.
For this test to be properly exercised there must be a assembler-time unknown expression that we can resolve at layout time. AFAIK this must be a text section ambiguity due to instruction relaxation. The only in-tree big-endian machine that does relax instructions is ARM. It's proving to not be a simple transliteration of the other test though.



Repository:
  rL LLVM

https://reviews.llvm.org/D46703