[PATCH] D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace

[Rumeet Dhindsa via Phabricator via llvm-commits]

rdhindsa added inline comments.


================
Comment at: lld/ELF/Driver.cpp:822-823
+        error(
+            "thinlto-object-suffix-replace expects 'old;new' format, but got " +
+            S.substr(30));
     } else if (!S.startswith("/") && !S.startswith("-fresolution=") &&
----------------
ruiu wrote:
> nit: it is perhaps better to split the long literal string into two like this
> 
>   error("thinlto-object-suffix-replace expects 'old;new' format, "
>         "but got " + S.substr(30));
> 
> so that the code looks better.
clang-format updates by splitting (" but got " + S.substr(30));) to two lines .


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46608