[PATCH] D46966: [lld] Use a real timestamp, with the option to use hash or explicit value

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: ruiu, thakis, rnk.

Using a deterministic value breaks Windows' AppCompat database in strange ways.

https://bugs.chromium.org/p/chromium/issues/detail?id=843199#29

for more information.

The TL;DR is that by default we need to write a real timestamp.  We can still get build determinism without breaking AppCompat, but the application will need to specify an explicit value to use for the time stamp.  So the method of always using a hash of the binary by default is changed to using the time stamp by default, but we add an option to use an explicit value or the old method of using a hash.


https://reviews.llvm.org/D46966

Files:
  lld/COFF/Config.h
  lld/COFF/Driver.cpp
  lld/COFF/Driver.h
  lld/COFF/DriverUtils.cpp
  lld/COFF/Options.td
  lld/COFF/Writer.cpp
  lld/test/COFF/timestamp.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46966.147142.patch
Type: text/x-patch
Size: 4959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180516/da025911/attachment.bin>