[PATCH] D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Hi,

I'm seeing a few link failures due to this commit (I think):

  Undefined symbols for architecture x86_64:
    "llvm::wasm::toString(llvm::wasm::WasmSymbolType)", referenced from:
        llvm::object::WasmSymbol::print(llvm::raw_ostream&) const in RandomAccessVisitorTest.cpp.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 (use -v to see invocation)

This affects the llvm-rc binary and some unit tests. I'm not sure why others aren't seeing the same build break -- possibly this is due to my building with modules. Here's a candidate fix:

  diff --git a/tools/llvm-rc/CMakeLists.txt b/tools/llvm-rc/CMakeLists.txt
  index 4cadc176691..175de768bf7 100644
  --- a/tools/llvm-rc/CMakeLists.txt
  +++ b/tools/llvm-rc/CMakeLists.txt
  @@ -1,6 +1,7 @@
   set(LLVM_LINK_COMPONENTS
     Option
     Support
  +  BinaryFormat
     )
   
   set(LLVM_TARGET_DEFINITIONS Opts.td)
  diff --git a/unittests/DebugInfo/CodeView/CMakeLists.txt b/unittests/DebugInfo/CodeView/CMakeLists.txt
  index 70a7b8af144..ea3adc6f2ea 100644
  --- a/unittests/DebugInfo/CodeView/CMakeLists.txt
  +++ b/unittests/DebugInfo/CodeView/CMakeLists.txt
  @@ -1,5 +1,6 @@
   set(LLVM_LINK_COMPONENTS
     DebugInfoCodeView
  +  BinaryFormat
     )
   
   add_llvm_unittest(DebugInfoCodeViewTests

Could you please take a look?


Repository:
  rL LLVM

https://reviews.llvm.org/D46847