[PATCH] D46961: [scudo] Quarantine optimization

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 10:50:13 PDT 2018


cryptoad added a comment.

In https://reviews.llvm.org/D46961#1101650, @dvyukov wrote:

> > Making it static const makes the compiler use __cxa_guard_acquire & __cxa_guard_release which we don't want to be able to stay free of libc++ dependencies.
>
> I meant keeping it as class member (not making it function-local static).


Sorry for the misunderstanding.
As a class member `constexpr` doesn't work for the previously mentioned reasons, and `static const` complains that the function `SizeClassMap::ClassId` is non-constexpr.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46961





More information about the llvm-commits mailing list