[PATCH] D46603: [Support] TimerGroup changes
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 16 10:42:14 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D46603#1101047, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46603#1100455, @george.karpenkov wrote:
>
> > I see four separate changes: s/.sys/mem one (can be committed without review), exposing printJSONValues and consequent adding of a lock, adding a constructor accepting a map, and fixing formatting in `printJSONValue`. All four look good to me, but probably should be reviewed separately.
>
>
> Thank you for taking a look!
> Posted as https://reviews.llvm.org/D46936, https://reviews.llvm.org/D46937, https://reviews.llvm.org/D46938, https://reviews.llvm.org/D46939
@alexfh & @george.karpenkov Thanks for reviewing those!
Not sure yet whether i will land them right away, or wait for clang-tidy part.
Repository:
rL LLVM
https://reviews.llvm.org/D46603
More information about the llvm-commits
mailing list