[PATCH] D45549: [DWARF v5] improved support for .debug_rnglists/consumer

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:366
+  if (Error E = RngList.extract(Data, HeaderOffset, End, &Offset)) {
+    llvm::consumeError(std::move(E));
+    return None;
----------------
JDevlieghere wrote:
> Would it be worth propagating the error and have this function return an `Expected<>`? 
> Would it be worth propagating the error and have this function return an Expected<>?
It would improve the reporting on invalid DW_AT_ranges attributes in the DIEs. Seems to require a few more changes in DWARFDie.cpp, but it would be worthwhile. I'll take a look at it.



https://reviews.llvm.org/D45549