[PATCH] D46955: [DAG] Prune cycle check in store merge.

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

Just some comments on the comments.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:546
+                                 SmallVectorImpl<MemOpLink> &StoreNodes,
+                                 SDNode *&Root);
 
----------------
Mention new arg in doc comment here and below.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13394
+    SDNode *N = StoreNodes[i].MemNode;
+    // Loops can only happen through the value operand(1).
+    auto *Op = N->getOperand(1).getNode();
----------------
This is not obvious. It'd be good to mention what you're excluding:
Operand 2: Address. Already verified all the addresses are constant offsets from each-other, so it would be impossible.
Operand 3: Offset, used only when isIndexed() is true, but we don't deal with indexed stores.


Repository:
  rL LLVM

https://reviews.llvm.org/D46955