[PATCH] D46898: Give shared modules in unittests the platform-native extension, make PipSqueak a MODULE

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 09:15:47 PDT 2018


philip.pfaffe added a comment.

Fundamentally looks good, but I'm slightly concerned about using different macros in the Code (`LTDL_SHLIB_EXT`) vs. in the build (`LLVM_PLUGIN_EXT`). Right now those are identical, but it might change. Can we export LLVM_PLUGIN_EXT in config.h?


https://reviews.llvm.org/D46898





More information about the llvm-commits mailing list