[PATCH] D46935: [ScopInfo] Remove usage of isl_set_n_basic_set()

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:1641
   ConditionSets.push_back(ConsequenceCondSet);
-  ConditionSets.push_back(isl_set_coalesce(AlternativeCondSet));
+  ConditionSets.push_back(AlternativeCondSet);
 
----------------
Why change this?


================
Comment at: lib/Analysis/ScopInfo.cpp:2658
 
-      auto *SuccInvalidDomain = InvalidDomainMap[SuccBB].copy();
-      SuccInvalidDomain =
-          isl_set_union(SuccInvalidDomain, AdjustedInvalidDomain);
-      SuccInvalidDomain = isl_set_coalesce(SuccInvalidDomain);
-      unsigned NumConjucts = isl_set_n_basic_set(SuccInvalidDomain);
+      auto SuccInvalidDomain = InvalidDomainMap[SuccBB];
+      SuccInvalidDomain = SuccInvalidDomain.unite(AdjustedInvalidDomain);
----------------
No auto here please. `DenseMap::operator[]` returns a reference, so this is actually dangerous.


Repository:
  rPLO Polly

https://reviews.llvm.org/D46935