[test-suite] r332395 - [test-suite][ubsan] Remove optimization that causes UB in SimpleMOC.

[Hal Finkel via llvm-commits]

On 05/15/2018 04:37 PM, Brian Homerding via llvm-commits wrote:
> I have spoken to John about the UB.  He asked if we wanted the change
> upstream also and I had left it up to him.  If this is a concern I
> will follow up on making the change upstream as well.

We should, to the extent possible, have these changes made upstream as well.

 -Hal

>
> Brian
>
> On Tue, May 15, 2018 at 3:49 PM, Davide Italiano <davide at freebsd.org
> <mailto:davide at freebsd.org>> wrote:
>
>     On Tue, May 15, 2018 at 1:42 PM, Brian Homerding via llvm-commits
>     <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>>
>     wrote:
>     > Author: homerdin
>     > Date: Tue May 15 13:42:38 2018
>     > New Revision: 332395
>     >
>     > URL: http://llvm.org/viewvc/llvm-project?rev=332395&view=rev
>     <http://llvm.org/viewvc/llvm-project?rev=332395&view=rev>
>     > Log:
>     > [test-suite][ubsan] Remove optimization that causes UB in SimpleMOC.
>     >
>     > This patch replaces the hand written ceil() with a call to
>     ceilf().  This small
>     > optimization is outside the primary kernel and should show
>     little to no
>     > difference in performance for the test suite.  Previously the UB
>     was only used
>     > in an '==' comparison for an early exit from the loop and had no
>     effect on the
>     > program behavior.
>     >
>
>     Have you considered making this change upstream and back porting? I'd
>     rather not create unnecessary divergencies, if possible.
>     https://github.com/ANL-CESAR/SimpleMOC
>     <https://github.com/ANL-CESAR/SimpleMOC>
>
>     --
>     Davide
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180516/63375b55/attachment.html>