[PATCH] D46900: [BasicAA] Fix handling of invariant group launders

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

We should also have a direct AA test (something like test/Analysis/BasicAA/cs-cs.ll).

Also, let's not repeat this problem in the future. Please add a comment both here and in CaptureTracking to remind people that intrinsics added to once place must be added to the other place.



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:138
+    // so it might not be considered an escape by isNonEscapingLocalObject
+    if (CS.getIntrinsicID() == Intrinsic::launder_invariant_group) {
+      return false;
----------------
Don't need the { } here.


Repository:
  rL LLVM

https://reviews.llvm.org/D46900