[PATCH] D46821: Update llvm-exegesis to cover latency through another opcode.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Only minor comments left.



================
Comment at: tools/llvm-exegesis/lib/Assembler.h:48
+
+// Creates an ObjectFile in the format understood by TM.
+// Note: the resulting object keeps a copy of Buffer so it can be discarded once
----------------
s/TM/the host/ (there's no TM anymore).


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.cpp:1
+#include "MCInstrDescView.h"
+
----------------
file header.


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.cpp:11
+
+namespace {
+
----------------
static


================
Comment at: tools/llvm-exegesis/lib/MCInstrDescView.cpp:96
+
+namespace {
+
----------------
static


================
Comment at: tools/llvm-exegesis/lib/RegisterAliasing.cpp:1
+#include "RegisterAliasing.h"
+
----------------
file header.


================
Comment at: tools/llvm-exegesis/lib/RegisterAliasing.h:41
+// Tracker.getOrigin(llvm::X86::BX) == -1;
+struct AliasingTracker {
+  // Construct a tracker from an MCRegisterClass.
----------------
Let's rename this to "RegisterAliasingTracker"


================
Comment at: tools/llvm-exegesis/lib/RegisterAliasing.h:75
+// A cache of existing trackers.
+struct AliasingTrackerCache {
+  // RegInfo must outlive the cache.
----------------
ditto


Repository:
  rL LLVM

https://reviews.llvm.org/D46821