[PATCH] D46916: [llvm-mca] Move the RegisterFile class into its own translation unit. NFC

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 16 01:34:08 PDT 2018


andreadb accepted this revision.
andreadb added a comment.

If the goal is to make the current DispatchUnit a DispatchStage, then this makes sense.

A couple of minor nits. Otherwise it looks good to me.



================
Comment at: tools/llvm-mca/Dispatch.h:22
-#include "llvm/MC/MCRegisterInfo.h"
-#include "llvm/MC/MCSubtargetInfo.h"
-#include <map>
----------------
This include should stay in this file.


================
Comment at: tools/llvm-mca/RegisterFile.h:22
+#include "llvm/MC/MCRegisterInfo.h"
+#include "llvm/MC/MCSubtargetInfo.h"
+
----------------
This include file is not needed.
Instead, you should include `llvm/MC/MCSchedule.h`.


https://reviews.llvm.org/D46916





More information about the llvm-commits mailing list