[PATCH] D46912: StructurizeCFG: Adjust the loop depth for a subregion to order the nodes correctly

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I still think this process of using the LoopDepth and sorting from anything other than RPO is fundamentally broken, but if everything is passing with this that's an improvement.



================
Comment at: test/Transforms/StructurizeCFG/AMDGPU/loop-subregion-misordered.ll:1
+; RUN: opt -mtriple=amdgcn-amd-amdhsa -S -structurizecfg %s | FileCheck %s
+;
----------------
Did you use update_test_checks for this? The comment is missing


================
Comment at: test/Transforms/StructurizeCFG/AMDGPU/loop-subregion-misordered.ll:175-177
+; The same function, except break to return block goes directly to the
+; return, which managed to hide the bug.
+; FIXME: Merge variant from backedge-id-bug-xfail
----------------
Does this comment still apply?


https://reviews.llvm.org/D46912