[PATCH] D46857: [CMake] Detect the compiler runtime and standard library

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/CMakeLists.txt:157
+    list(APPEND SANITIZER_CXX_ABI_LIBRARY "c++")
+  else()
+    if(TARGET cxxabi_shared OR (HAVE_LIBCXXABI AND NOT LIBCXX_ENABLE_STATIC_ABI_LIBRARY))
----------------
What does happen with the unwind?


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:155
       set(CMAKE_EXE_LINKER_FLAGS ${SAVED_CMAKE_EXE_LINKER_FLAGS})
+      message(ERROR "Cannot compile ${TARGET_${arch}_OUTPUT}")
     endif()
----------------
Should this message be in some if() statement? 


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:329
+  endif()
+  execute_process(
+      COMMAND ${COMPILER_COMMAND}
----------------
why not to use try_compile?


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:354
+    string(REGEX REPLACE "([][+.*?()^$])" "\\\\\\1" linker "${linker}")
+    set(linker_regex "^( *|.*[/\\])(${linker}|([^/\\]+-)?ld|collect2)[^/\\]*( |$)")
+    set(linker_exclude_regex "collect2 version |^[A-Za-z0-9_]+=|/ldfe ")
----------------
Should this variable names be upper case?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46857