[PATCH] D46908: [Debugfiy][WIP] Print the pass name next to the result

[Vedant Kumar via Phabricator via llvm-commits]

vsk added subscribers: tyb0807, debug-info.
vsk added a comment.

Thanks for the patch. Comments inline --



================
Comment at: tools/opt/Debugify.cpp:195
+  outs() << Banner << " [" << AttachedPassName << "]: "
+         << (HasErrors ? "FAIL" : "PASS") << '\n';
   if (HasErrors) {
----------------
You'll need to update test/DebugInfo/debugify-each.ll to reflect this change.


================
Comment at: tools/opt/Debugify.cpp:258
+      Strip(Strip),
+      AttachedPassName(AttachedPassName) {}
 
----------------
Please use clang-format to format your diffs. See:
- https://clang.llvm.org/docs/ClangFormat.html
- https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/clang-format-diff.py


================
Comment at: tools/opt/PassPrinters.h:67
+  llvm::PreservedAnalyses run(llvm::Module &M, llvm::ModuleAnalysisManager &AM,
+                              llvm::StringRef AttachedPassName = "");
 };
----------------
There isn't support for -debugify-each in the newPM yet, so there's no need to tackle that in this patch. I think we should leave newPM-related changes to a future patch. 


================
Comment at: tools/opt/PassPrinters.h:67
+  llvm::PreservedAnalyses run(llvm::Module &M, llvm::ModuleAnalysisManager &AM,
+                              llvm::StringRef AttachedPassName = "");
 };
----------------
vsk wrote:
> There isn't support for -debugify-each in the newPM yet, so there's no need to tackle that in this patch. I think we should leave newPM-related changes to a future patch. 
I think 'NameOfWrappedPass' would be a more accurate/descriptive name here.


Repository:
  rL LLVM

https://reviews.llvm.org/D46908