[PATCH] D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 15 15:11:51 PDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332409: [AMDGPU] Fix handling of void types in isLegalAddressingMode (authored by rampitec, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40405?vs=146925&id=146929#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40405
Files:
llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpp
llvm/trunk/test/CodeGen/AMDGPU/lsr-void.ll
Index: llvm/trunk/test/CodeGen/AMDGPU/lsr-void.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/lsr-void.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/lsr-void.ll
@@ -0,0 +1,37 @@
+; RUN: llc -march=amdgcn < %s | FileCheck -check-prefix=GCN %s
+
+ at array = external addrspace(4) constant [32 x [800 x i32]], align 4
+
+; GCN-LABEL: {{^}}test_lsr_voidty:
+define amdgpu_kernel void @test_lsr_voidty() {
+entry:
+ br label %for.body
+
+for.body: ; preds = %for.body.i, %entry
+ br label %for.body.i
+
+for.body.i: ; preds = %for.body.i, %for.body
+ %ij = phi i32 [ 0, %for.body ], [ %inc14, %for.body.i ]
+ %tmp = load i32, i32 addrspace(5)* undef, align 4
+ %inc13 = or i32 %ij, 2
+ %shl = shl i32 1, 0
+ %and = and i32 %shl, %tmp
+ %tobool = icmp eq i32 %and, 0
+ %add = mul nuw nsw i32 %inc13, 5
+ %tmp1 = zext i32 %add to i64
+ %arrayidx8 = getelementptr inbounds [32 x [800 x i32]], [32 x [800 x i32]] addrspace(4)* @array, i64 0, i64 undef, i64 %tmp1
+ %tmp2 = load i32, i32 addrspace(4)* %arrayidx8, align 4
+ %and9 = select i1 %tobool, i32 0, i32 %tmp2
+ %xor = xor i32 undef, %and9
+ %inc1 = or i32 %ij, 3
+ %add2 = mul nuw nsw i32 %inc1, 5
+ %add6 = add nuw nsw i32 %add2, 1
+ %tmp3 = zext i32 %add6 to i64
+ %arrayidx9 = getelementptr inbounds [32 x [800 x i32]], [32 x [800 x i32]] addrspace(4)* @array, i64 0, i64 undef, i64 %tmp3
+ %tmp4 = bitcast i32 addrspace(4)* %arrayidx9 to <4 x i32> addrspace(4)*
+ %tmp5 = load <4 x i32>, <4 x i32> addrspace(4)* %tmp4, align 4
+ %reorder_shuffle2 = shufflevector <4 x i32> %tmp5, <4 x i32> undef, <4 x i32> <i32 3, i32 2, i32 1, i32 0>
+ %tmp6 = select <4 x i1> undef, <4 x i32> zeroinitializer, <4 x i32> %reorder_shuffle2
+ %inc14 = add nuw nsw i32 %ij, 4
+ br i1 undef, label %for.body, label %for.body.i
+}
Index: llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpp
===================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpp
+++ llvm/trunk/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -746,7 +746,7 @@
// will use a MUBUF load.
// FIXME?: We also need to do this if unaligned, but we don't know the
// alignment here.
- if (DL.getTypeStoreSize(Ty) < 4)
+ if (Ty->isSized() && DL.getTypeStoreSize(Ty) < 4)
return isLegalGlobalAddressingMode(AM);
if (Subtarget->getGeneration() == SISubtarget::SOUTHERN_ISLANDS) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40405.146929.patch
Type: text/x-patch
Size: 2492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180515/600bec36/attachment.bin>
More information about the llvm-commits
mailing list