[PATCH] D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 14:47:06 PDT 2018


alekseyshl added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h:32
+#if ((SI_POSIX != 0) == (SI_WINDOWS != 0)) && !SANITIZER_FUCHSIA \
+  && !SANITIZER_RTEMS
 # error "Windows is not POSIX!"
----------------
How SANITIZER_FUCHSIA and SANITIZER_RTEMS are related to "Windows is not POSIX!" message? Both are not Windows indeed.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cc:20
 
 // sanitizer_symbolizer_fuchsia.cc implements these differently for Fuchsia.
+#if !SANITIZER_FUCHSIA && !SANITIZER_RTEMS
----------------
The comment should mention RTEMS too.


Repository:
  rL LLVM

https://reviews.llvm.org/D46454





More information about the llvm-commits mailing list