[test-suite] r332395 - [test-suite][ubsan] Remove optimization that causes UB in SimpleMOC.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue May 15 13:49:05 PDT 2018


On Tue, May 15, 2018 at 1:42 PM, Brian Homerding via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: homerdin
> Date: Tue May 15 13:42:38 2018
> New Revision: 332395
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332395&view=rev
> Log:
> [test-suite][ubsan] Remove optimization that causes UB in SimpleMOC.
>
> This patch replaces the hand written ceil() with a call to ceilf().  This small
> optimization is outside the primary kernel and should show little to no
> difference in performance for the test suite.  Previously the UB was only used
> in an '==' comparison for an early exit from the loop and had no effect on the
> program behavior.
>

Have you considered making this change upstream and back porting? I'd
rather not create unnecessary divergencies, if possible.
https://github.com/ANL-CESAR/SimpleMOC

--
Davide


More information about the llvm-commits mailing list