[PATCH] D46886: Escape ]]> in xunit xml output

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In https://reviews.llvm.org/D46886#1099816, @cmatthews wrote:

> The test does not care what the return code of lit is, just that the xml output is correct.


That seems a little risky to me. The lit command could fail to execute and you could pick up an old copy of `%t.xunit.xml` from a previously passing run because AFAIK `%t.xunit.xml` expands to something deterministic.
Because the exit code is completely ignored we would definitely miss this, where-as if the exit code was checked we would be less likely (but not guaranteed) to miss this.
In reality we probably ought to `rm -f %t.xunit.xml` first before running the test.


Repository:
  rL LLVM

https://reviews.llvm.org/D46886